Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve GDB usage in CI #5429

Merged
merged 4 commits into from
Mar 1, 2023
Merged

Improve GDB usage in CI #5429

merged 4 commits into from
Mar 1, 2023

Conversation

rmccorm4
Copy link
Collaborator

  1. Don't spam gdb log/error if process has already exited. ex: tests that expect server to fail startup
  2. Try to get backtrace from any dumped corefiles if any. Most CI runners will have core dumped to current directory if test segfaults, so we can try to load it and get a backtrace after it happens.

@rmccorm4
(1) Don't spam gdb log/error if process has already exited, (2) Try t…
5376815 
…o get backtrace from any dumped corefiles if any
tanmayv25
tanmayv25 previously approved these changes Mar 1, 2023
View reviewed changes
dyastremsky
dyastremsky previously approved these changes Mar 1, 2023
View reviewed changes
@rmccorm4 rmccorm4 dismissed stale reviews from dyastremsky and tanmayv25 via eacd90c March 1, 2023 00:23
@rmccorm4 rmccorm4 merged commit dfa151e into main Mar 1, 2023
@rmccorm4 rmccorm4 deleted the rmccormick-segfault branch March 1, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dyastremsky dyastremsky dyastremsky approved these changes

@tanmayv25 tanmayv25 tanmayv25 approved these changes

@GuanLuo GuanLuo Awaiting requested review from GuanLuo

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rmccorm4 @tanmayv25 @dyastremsky