Add mismatch key vs name gpu io test #5143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
GuanLuo
reviewed
Dec 7, 2022
| # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE | ||
| # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | ||
|
|
||
| name: "mismatch_key_name" |
There was a problem hiding this comment.
I would name it differently, IIUC, it is still an valid model, just that its signature def expose the I/O in names different from the tensor names in the TF graph.
I think the model created from gen_tag_sigdef.py has this characteristic so you should be able to re-use that for this test case. CC @jbkyang-nvi
|
With the sig_tag0 model, when the test is run without the TF change, the server will fail to start: |
kthui
requested review from
GuanLuo and
nv-kmcgill53
and removed request for
nv-kmcgill53
|
CC @nv-kmcgill53, PR for TF gpu_io MakeCallable fix. |
GuanLuo
reviewed
Dec 7, 2022
| exit 1 | ||
| fi | ||
| kill $SERVER_PID | ||
| wait $SERVER_PID |
There was a problem hiding this comment.
Send request to test if the model is working.
kthui
force-pushed
the
jacky-fix-make-callable-name
branch
from
c648b81
to
2ad7532
Compare
kthui
force-pushed
the
jacky-fix-make-callable-name
branch
from
2ad7532
to
697dc6b
Compare
GuanLuo
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current L0_tf_gpu_io test relies on well created TF savedmodels, which the I/O tensors key and name will always match, but this is not the case in the real world. The added model and test is derived from the same "qa_identity_model_repository/savedmodel_nobatch_zero_1_float32" but deliberately made the key and name to not match for testing the change.
Related PR: triton-inference-server/tensorflow_backend#84