Add LD_PRELOAD for sequence batcher/infer tests #5125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krishung5
previously approved these changes
Dec 2, 2022
mc-nv
reviewed
Dec 2, 2022
qa/L0_infer/test.sh
Outdated
| # PyTorch on SBSA requires libgomp to be loaded first. See the following | ||
| # GitHub issue for more information: | ||
| # https://github.com/pytorch/pytorch/issues/2575 | ||
| if [ $TEST_REPO_ARCH = "arm_a100" ]; then |
There was a problem hiding this comment.
@Tabrizian
I think there should be == sign for condition.
Also wondering if we can compare against HOSTTYPE or uname -m result instead of using NV value?
There was a problem hiding this comment.
Fixed the variable name. Both = and == will compare the equality. See below for more info:
mc-nv
approved these changes
Dec 5, 2022
krishung5
approved these changes
Dec 5, 2022
mc-nv
pushed a commit
that referenced
this pull request
Dec 5, 2022
* Add LD_PRELOAD for sequence batcher/infer tests * Review edit
mc-nv
pushed a commit
that referenced
this pull request
Dec 5, 2022
* Add LD_PRELOAD for sequence batcher/infer tests * Review edit
mc-nv
pushed a commit
that referenced
this pull request
Dec 5, 2022
* Add LD_PRELOAD for sequence batcher/infer tests * Review edit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.