Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Using alternative managed symbolic links for library paths (… #5060

Merged
merged 1 commit into from
Nov 10, 2022

Conversation

mc-nv
Copy link
Contributor

@mc-nv mc-nv commented Nov 10, 2022

#4982)"

This reverts commit f036cb0.

@rmccorm4
Copy link
Collaborator

What were the issues with the symlinks?

@mc-nv
Copy link
Contributor Author

mc-nv commented Nov 10, 2022

What were the issues with the symlinks?

Good question @rmccorm4

The issue lays down in compilation process for pytorch_backend whic uses libtorch_cuda.so as one of the dependencies, and shipped with it.

Our CPU only container doesn't has all necessary CUDA dependency libraries inside container for libtorch_cuda.so and we feed it manually as a result we unable to load tritonserver unless those files with respective names would be accessible in PATH:

root@7e8cdddb2318:/opt/tritonserver/qa/L0_infer#  ldd /opt/tritonserver/backends/pytorch/libtorch_cuda.so  | grep found
        libcudart.so.11.0 => not found
        libcusparse.so.11 => not found
        libcurand.so.10 => not found
        libnvToolsExt.so.1 => not found
        libcufft.so.10 => not found
        libcublas.so.11 => not found
        libcudart.so.11.0 => not found
        libcudart.so.11.0 => not found
        libcupti.so.11.8 => not found

@rmccorm4
Copy link
Collaborator

Maybe we can revisit a more generic solution in the future, even if just copying via wildcard to get the necessary versioned files if that works

@mc-nv
Copy link
Contributor Author

mc-nv commented Nov 10, 2022

Maybe we can revisit a more generic solution in the future, even if just copying via wildcard to get the necessary versioned files if that works

I'm totally agree with you @rmccorm4 , that we need to address it and if possible find a solution to handle it.

@mc-nv mc-nv merged commit dc8bdcf into main Nov 10, 2022
@mc-nv mc-nv deleted the mchornyi-main branch November 23, 2022 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants