Remove LD_PRELOAD from L0_infer/L0_sequence_batcher tests #5047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuanLuo
previously approved these changes
Nov 8, 2022
|
@Tabrizian Can you provide more context? Did the issue got fixed with new release of pytorch and we no longer need to pre load this library? |
|
@tanmayv25 Sorry, I missed this comment. I wanted to remove this so that if the tests fail we can catch it and fix the issue. |
Tabrizian
force-pushed
the
imant-ld-preload
branch
from
238403e
to
c0553bc
Compare
|
CI is passing here: https://gitlab-master.nvidia.com/dl/dgx/tritonserver/-/jobs/48637696 |
rmccorm4
approved these changes
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.