Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sphinx support for documentation #4949

Merged
merged 5 commits into from
Oct 6, 2022
Merged

Add sphinx support for documentation #4949

merged 5 commits into from
Oct 6, 2022

Conversation

dzier
Copy link
Collaborator

@dzier dzier commented Oct 5, 2022

There are a lot of new files here needed for Sphinx. For review, please look at changes made to .md files, or any new .md files. DM me for a link to the compiled documentation version to see what it will look like.

GuanLuo
GuanLuo previously approved these changes Oct 6, 2022
:maxdepth: 1
:caption: User Guide

user_guide/performance_tuning
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this code generated? Or we need to add the pointer to newly added markdown file to properly render the table of content.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not user generated. It is the templates that sphinx uses to render the left side nav bar. It is some sphinx magic that makes it work and is not intended to be read on GitHub. Note the {toctree} at the top of the section. This tells Sphinx to render a table of contents and it has it's own method to generate the correct links from this. See https://www.sphinx-doc.org/en/master/usage/restructuredtext/directives.html#directive-toctree for more info.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant to ask that if we are adding new documentation page for new feature (say "protocol/extension_new_feature.md"), do we need to manually add the entry "protocol/extension_new_feature" in this file to make sure it is included in the rendered documentation.

I was hoping that this file is automatically generated by a script that scans the file directory for documentation

@@ -274,11 +274,11 @@ issues since non-supported versions are not tested.
## <a name="windows"></a>Building for Windows 10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI that we can remove the a tag if we use title a ref link instead.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted, I can do that.

@tanayvarshney
Copy link
Collaborator

Can we add the link to the hosted docs in the about section?

@dzier dzier merged commit e9ef15b into main Oct 6, 2022
@dzier dzier deleted the dzier-publish-docs branch October 6, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants