Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for PA metrics feature #4871

Merged
merged 4 commits into from
Sep 14, 2022
Merged

Conversation

matthewkotila
Copy link
Contributor

No description provided.


Perf Analyzer can optionally collect and output server-side metrics, such as GPU
utilization and GPU power usage. To enable this collection/output, use the
`--verbose-csv` (with the `-f <filename>` option) and `--collect-metrics`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would split up talking about collection (--collect-metrics) vs output to csv since soon it will also output to stdout. Also the csv stuff should go after talking about the metrics-url option

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rearranged 👍

docs/user_guide/perf_analyzer.md Outdated Show resolved Hide resolved
docs/user_guide/perf_analyzer.md Outdated Show resolved Hide resolved
tgerdesnv
tgerdesnv previously approved these changes Sep 13, 2022
Tabrizian
Tabrizian previously approved these changes Sep 13, 2022
docs/user_guide/perf_analyzer.md Outdated Show resolved Hide resolved
Note that all metrics are per-GPU in the case of multi-GPU systems.

To output these server-side metrics to a CSV file, use the `-f <filename>` and
`--verbose-csv` CLI options. The output CSV will contain one column per metric.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, why is the extra --verbose-csv needed? Shouldn't specifying a filename -f be sufficient to say we want the output to the file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember the full rationale behind --verbose-csv. @tgerdesnv @nv-braf can discuss. What I remember is that --verbose-csv was added as a way to preserver "the old" csv output format (i.e. not using --verbose-csv) for backwards compatibility. Somewhere in the design discussions for this metrics feature, we decided that the metrics would only be output on this "new" csv output format (i.e. using --verbose-csv).

Co-authored-by: Ryan McCormick <rmccormick@nvidia.com>
@matthewkotila matthewkotila merged commit 7cc7456 into main Sep 14, 2022
@matthewkotila matthewkotila deleted the matthewkotila-pa-docs branch September 14, 2022 16:51
mc-nv pushed a commit that referenced this pull request Sep 14, 2022
* Add documentation for PA metrics feature

* Add missing documentation

* Addressed comments

* Update docs/user_guide/perf_analyzer.md

Co-authored-by: Ryan McCormick <rmccormick@nvidia.com>

Co-authored-by: Ryan McCormick <rmccormick@nvidia.com>
mc-nv pushed a commit that referenced this pull request Sep 14, 2022
* Add documentation for PA metrics feature

* Add missing documentation

* Addressed comments

* Update docs/user_guide/perf_analyzer.md

Co-authored-by: Ryan McCormick <rmccormick@nvidia.com>

Co-authored-by: Ryan McCormick <rmccormick@nvidia.com>
mc-nv pushed a commit that referenced this pull request Sep 14, 2022
* Add documentation for PA metrics feature

* Add missing documentation

* Addressed comments

* Update docs/user_guide/perf_analyzer.md

Co-authored-by: Ryan McCormick <rmccormick@nvidia.com>

Co-authored-by: Ryan McCormick <rmccormick@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants