Cat SERVER_LOG when failing to grep it #4252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
If it's useful to have both the client and the server log when troubleshooting then I would suggest leaving in the "$cat $MINIMAL_LOG" in. If that interaction is not useful for identifying what went wrong then the replacement of the client log with the server log is fine for me.
|
I think it's better to have more info than less when debugging, so I'll include both. |
nv-kmcgill53
approved these changes
Apr 19, 2022
dyastremsky
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we cat the client log when failing to find something in server log output - this makes it hard to see what happened in CI test failure output.