Set http address for metrics when http service is disable #4175
Conversation
| @@ -133,6 +133,10 @@ std::unique_ptr<triton::server::HTTPServer> metrics_service_; | |||
| bool allow_metrics_ = true; | |||
| int32_t metrics_port_ = 8002; | |||
| float metrics_interval_ms_ = 2000; | |||
| #ifndef TRITON_ENABLE_HTTP | |||
| // Need to set http address for metrics when http service is disable | |||
| std::string http_address_ = "0.0.0.0"; | |||
There was a problem hiding this comment.
We are assuming the http address and metrics address is always the same? I guess that works fine but I would recommend adding a comment about the same.
There was a problem hiding this comment.
Yes, right now we are using the same address for http and metrics. Comment added, please review. Please also let me know if we want to use a different address for metrics. I can make changes for that.
There was a problem hiding this comment.
Thanks. I think for now we can use the same http address for metrics. Let's worry about that only when we have future requests.
For now make sure the docs / help indicates that http address is reused for metrics endpoint as well.
There was a problem hiding this comment.
Updated documentation, please review.
krishung5
force-pushed
the
krish-correct-address-for-metrics
branch
from
3572cb2
to
64a24f5
Compare
No description provided.