-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for optional input in Python backend #4164
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuanLuo
reviewed
Apr 5, 2022
qa/L0_backend_python/python_test.py
Outdated
size=shape, | ||
dtype=np.int32) | ||
else: | ||
# Set the input0 dummy data for testing purposes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really "dummy" data, should say set to default input0 data that the model uses if not provided.
GuanLuo
previously approved these changes
Apr 5, 2022
tanmayv25
requested changes
Apr 6, 2022
tanmayv25
previously approved these changes
Apr 6, 2022
GuanLuo
previously approved these changes
Apr 6, 2022
Tabrizian
force-pushed
the
imant-optional
branch
from
April 7, 2022 14:38
0b10184
to
d6db18a
Compare
Tabrizian
force-pushed
the
imant-optional
branch
from
April 7, 2022 20:24
d6db18a
to
be30217
Compare
CI passed: 4456183 ✔️ |
GuanLuo
approved these changes
Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.