Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for optional input in Python backend #4164

Merged
merged 5 commits into from
Apr 8, 2022
Merged

Conversation

Tabrizian
Copy link
Member

No description provided.

size=shape,
dtype=np.int32)
else:
# Set the input0 dummy data for testing purposes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really "dummy" data, should say set to default input0 data that the model uses if not provided.

@Tabrizian Tabrizian requested a review from GuanLuo April 5, 2022 22:06
GuanLuo
GuanLuo previously approved these changes Apr 5, 2022
qa/L0_backend_python/python_test.py Outdated Show resolved Hide resolved
qa/python_models/optional/model.py Show resolved Hide resolved
tanmayv25
tanmayv25 previously approved these changes Apr 6, 2022
GuanLuo
GuanLuo previously approved these changes Apr 6, 2022
@Tabrizian
Copy link
Member Author

CI passed: 4456183 ✔️

@Tabrizian Tabrizian merged commit b65c77c into main Apr 8, 2022
@Tabrizian Tabrizian deleted the imant-optional branch April 8, 2022 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants