Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shared memory monitor on windows #4148

Merged
merged 2 commits into from
Apr 4, 2022
Merged

Fix shared memory monitor on windows #4148

merged 2 commits into from
Apr 4, 2022

Conversation

Tabrizian
Copy link
Member

No description provided.

CoderHam
CoderHam suggested changes Apr 4, 2022
View reviewed changes
qa/common/shm_util.py Outdated
@@ -29,10 +29,10 @@
import numpy as np
import time
from ctypes import *
import platform
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@Tabrizian Tabrizian requested a review from CoderHam April 4, 2022 16:45
@Tabrizian Tabrizian merged commit ceb856e into main Apr 4, 2022
@Tabrizian Tabrizian deleted the imant-fix-windows branch April 4, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuanLuo GuanLuo GuanLuo approved these changes

@CoderHam CoderHam CoderHam approved these changes

@dyastremsky dyastremsky Awaiting requested review from dyastremsky

@tanmayv25 tanmayv25 Awaiting requested review from tanmayv25

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tabrizian @CoderHam @GuanLuo