Improve the stability of preserve ordering test in L0_batcher #4117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanmayv25
requested review from
deadeyegoodwin,
Tabrizian,
CoderHam,
GuanLuo and
nv-kmcgill53
GuanLuo
approved these changes
Mar 28, 2022
CoderHam
approved these changes
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the intermittent failure on L0_batcher preserve ordering subtest.
Notice how just capturing the timestamp just before:
Fixes the issue. Using HTTP_SEND_START itself did not fix the issue. Need to study libevhttp library to figure out why the order gets broken.
With INFER_RESPONSE_COMPLETE trace point the order is as expected.