-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add S3 multiple cloud repository test coverage #4109
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoderHam
changed the title
Add S3 multiple cloud repository coverage
Add S3 multiple cloud repository test coverage
Mar 24, 2022
tanmayv25
requested changes
Mar 25, 2022
CoderHam
force-pushed
the
hemantj-multi-cloud
branch
from
March 25, 2022 18:56
f590384
to
cc911e9
Compare
tanmayv25
previously approved these changes
Mar 25, 2022
GuanLuo
requested changes
Mar 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use test util
As discussed I want to change to use test util across all cloud repositories but would like to make those changes in a follow up PR. I have a jira ticket for the same. |
CoderHam
force-pushed
the
hemantj-multi-cloud
branch
from
March 28, 2022 19:42
cc911e9
to
705ca64
Compare
tanmayv25
approved these changes
Mar 28, 2022
GuanLuo
approved these changes
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.