Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document HTTP compression feature #3368

Merged
merged 2 commits into from
Sep 15, 2021
Merged

Document HTTP compression feature #3368

merged 2 commits into from
Sep 15, 2021

Conversation

tanmayv25
Copy link
Contributor

No description provided.

deadeyegoodwin
deadeyegoodwin previously approved these changes Sep 14, 2021
@@ -47,6 +47,13 @@ model health, metadata and statistics. Additional endpoints allow
model loading and unloading, and inferencing. See the KFServing and
extension documentation for details.

### HTTP Options
Triton provides following configuring options for server-client network transactions over HTTP protocol.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the following configuration options

@@ -70,7 +77,7 @@ Triton allows the on-wire compression of request/response messages by exposing f

* `--grpc-infer-response-compression-level`

For client-side documentation, see [Client-Side GRPC Compression](https://github.com/triton-inference-server/client/tree/main#compression)
For client-side documentation, see [Client-Side GRPC Compression](https://github.com/triton-inference-server/client/tree/main#compression-1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you adding the -1 in the end?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The compression without -1 links to http compression and compression-1 links to the second compression sub-heading for grpc.
https://github.com/triton-inference-server/client/tree/main#compression
https://github.com/triton-inference-server/client/tree/main#compression-1

I too was not aware of this way of indexing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL

@tanmayv25 tanmayv25 merged commit 78ef50c into main Sep 15, 2021
@tanmayv25 tanmayv25 deleted the tanmayv-doc branch September 15, 2021 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants