Fix long-running stress test #3346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krishung5
force-pushed
the
krish-fix-stress-test
branch
from
938a6a3
to
e798914
Compare
deadeyegoodwin
suggested changes
Sep 9, 2021
qa/L0_long_running_stress/stress.py
Outdated
| @@ -51,7 +51,7 @@ | |||
|
|
|||
| FLAGS = None | |||
| CORRELATION_ID_BLOCK_SIZE = 100 | |||
There was a problem hiding this comment.
Make CORRELATION_ID_BLOCK_SIZE much larger... 1024 * 1024
qa/L0_long_running_stress/stress.py
Outdated
| # instead of being a sequence missing start flag, which gives results | ||
| # not expected. | ||
| if test_case_name == "sequence_no_start": | ||
| sequence_id *= 10 |
There was a problem hiding this comment.
Just multiplying by 10 seems a little magical... I think there is a better way described below
There was a problem hiding this comment.
Will remove this part and use the original approach mentioned below.
deadeyegoodwin
previously approved these changes
Sep 9, 2021
CoderHam
previously approved these changes
Sep 10, 2021
added 7 commits
September 10, 2021 12:44
krishung5
dismissed stale reviews from CoderHam and deadeyegoodwin
via
a6b98c8
krishung5
force-pushed
the
krish-fix-stress-test
branch
from
8a38abb
to
a6b98c8
Compare
CoderHam
approved these changes
Sep 10, 2021
|
@deadeyegoodwin I think the original logic doesn't work well is because in the original sequence stress test, we only serve one model, so we can just use the last_seq_choice to see if the last sequence case is some no-end cases. But we are serving multiple models in this stress test, so we need to remember which model is used for the no-end cases. |
deadeyegoodwin
approved these changes
Sep 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.