Fix default values for backend configs when not set #3317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
CoderHam
commented
Sep 2, 2021
CoderHam
commented
- MinComputeCapability
- BackendDir
- StrictModelConfig
CoderHam
requested review from
deadeyegoodwin,
krishung5,
GuanLuo and
tanmayv25
deadeyegoodwin
suggested changes
Sep 3, 2021
src/core/tritonserver.cc
Outdated
| std::to_string(min_compute_capability)); | ||
| loptions->AddBackendConfig( | ||
| std::string(), "backend-directory", loptions->BackendDir()); | ||
|
|
||
| lserver->SetStrictReadinessEnabled(loptions->StrictReadiness()); | ||
| lserver->SetExitTimeoutSeconds(loptions->ExitTimeout()); | ||
| lserver->SetBackendCmdlineConfig(loptions->BackendCmdlineConfigMap()); |
There was a problem hiding this comment.
This line is where all the AddBackendConfig commands must be completed before. Can you move the AddBackendConfig calls and this line does to after the other option setting (line1740) and put a comment indicating as much.
- MinComputeCapability - BackendDir - StrictModelConfig
CoderHam
force-pushed
the
hemantj-server-options
branch
from
ddf32fc
to
b9c5427
Compare
deadeyegoodwin
approved these changes
Sep 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.