Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for BLS GPU tensor #3310

Merged
merged 1 commit into from
Sep 2, 2021
Merged

Add test for BLS GPU tensor #3310

merged 1 commit into from
Sep 2, 2021

Conversation

Tabrizian
Copy link
Member

No description provided.

deadeyegoodwin
deadeyegoodwin approved these changes Sep 1, 2021
View reviewed changes
Copy link
Contributor

@deadeyegoodwin deadeyegoodwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this allow L0_io test with python backend with all combinations of tensor memory types?

@Tabrizian
Copy link
Member Author

L0_io tests the input/output tensor combinations but it doesn't test BLS tensor combinations. There is a subtest in L0_backend_python test that was used to test passing the identity tensors in Python backend. It was created to cover some corner cases were the model returned the same GPU tensor as the final tensor. I have extended that test here to do the same for BLS.

@Tabrizian Tabrizian merged commit 0e25172 into main Sep 2, 2021
@Tabrizian Tabrizian deleted the imant-bls-gpu-tensor branch September 2, 2021 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deadeyegoodwin deadeyegoodwin deadeyegoodwin approved these changes

@CoderHam CoderHam Awaiting requested review from CoderHam

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tabrizian @deadeyegoodwin