Fix VS install to wait for install to complete #3050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoderHam
suggested changes
Jun 25, 2021
Dockerfile.win10.min
Outdated
| # Download and install Build Tools for Visual Studio. VS seems to not | ||
| # Download and install Build Tools for Visual Studio. The use of | ||
| # powershell for the install seems to be required to make the command | ||
| # wait for the install to complete before continuing. VS seems to not |
There was a problem hiding this comment.
We can remove the "not commonly" double negative to "VS seems to commonly .."
Dockerfile.win10.min
Outdated
| # Download and install Build Tools for Visual Studio. VS seems to not | ||
| # Download and install Build Tools for Visual Studio. The use of | ||
| # powershell for the install seems to be required to make the command | ||
| # wait for the install to complete before continuing. VS seems to not | ||
| # uncommonly break something or other so we want to stick with a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.