Update based on Feedback from TME #3003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mengdong these changes look good to me. Have they been tested? |
mengdong
changed the title
|
Hi Hemant, I marked this as WIP now, TME team will add additional feedback they have. Most changes are not functional but documentation. |
mengdong
changed the title
|
@CoderHam I realize this has not been closed. Do I need to rebase from master or the pull request is good to merged, and yes we have tested this. |
2 fixes in README to resolve startup error user might run into
increase user numbers to 1000 and step to 50
|
@CoderHam I just rebased from master, mostly TME feedback so nothing substantial |
LGTM 👍 |
CoderHam
approved these changes
Jul 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 fixes in README to resolve startup error user might run into