Refactor Python backend tests #2945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tabrizian
commented
May 31, 2021
| if (!StartEndpoints(server, trace_manager, shm_manager)) { | ||
| exit(1); | ||
| } | ||
|
|
There was a problem hiding this comment.
I moved the registration of endpoints after the registration of signal handling so that when the server is ready the destructors are called properly.
CoderHam
approved these changes
Jun 2, 2021
maaquib
pushed a commit
to maaquib/server
that referenced
this pull request
Jun 3, 2021
maaquib
pushed a commit
to maaquib/server
that referenced
this pull request
Jun 3, 2021
deadeyegoodwin
pushed a commit
that referenced
this pull request
Jun 11, 2021
* Refactor Python backend tests (#2945) * Update GKE deployer to 21.05, add scripts for benchmarking (#2942) * upgrade to 21.05, add sample benchmark materials * configuration change * fix major * fix major * Update README.md * add client deployment * Fix wrong value in credentials for AWS Helm Chart (#2950) * Fix wrong value in credentials for AWS Helm Chart * Secrets.yaml deleted from gcp as it's not used * Use device specific input in the input collector and backend (#2898) * Use device specific input in the input collector and backend * Draft: Add host policy changes * Remove testing redirection * Update according to review comments * Use fallback input buffer properties consistently * Update comment Co-authored-by: msridhara <msridhara@msridhara-ub-desktop.nvidia.com> * Add non-default model name support to Sagemaker serve script Co-authored-by: Iman Tabrizian <itabrizian@nvidia.com> Co-authored-by: Dong <mengdong@users.noreply.github.com> Co-authored-by: Martin Beyer <tinchobeyer2@gmail.com> Co-authored-by: madhu-nvda <77174106+madhu-nvda@users.noreply.github.com> Co-authored-by: msridhara <msridhara@msridhara-ub-desktop.nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR breaks the Python backend tests into multiple subsections. It also fixes a minor bug in server where the Triton server was not calling the backend destructors after it has become ready.