Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update repoagent documentation #2499

Merged
merged 2 commits into from
Feb 10, 2021
Merged

Update repoagent documentation #2499

merged 2 commits into from
Feb 10, 2021

Conversation

deadeyegoodwin
Copy link
Contributor

No description provided.

@deadeyegoodwin
Copy link
Contributor Author

@GuanLuo read carefully the triton steps listed in this doc, especially the forward and reverse orders. I don't think this matches the implementation so we may need to discuss.


* Load the model's configuration file (config.pbtxt) and extract the
*ModelRepositoryAgents* settings. Even if a repository agent
modifies the config.pbtxt file, the repository agent settings from
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deadeyegoodwin Does this imply the model will be loaded using the config.pbtxt file in the final model location? i.e. after all agents are invoked, Triton will read the config again from the location that the last agent points to.

The reverse order is not implemented right now, but it should be a trivial change as the agent models are not depending to each other except during TRITONREPOAGENT_ACTION_LOAD

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, initially the repository manager should only need the repoagent part of the initial config to determine which (if any) repo agents are specified for the model. After invoking all the repoagents with LOAD successfully then the repository manager should treat the final repository location as if it was directly presented by the user. So config.pbtxt should be used, etc.

I will file a ticket for the reverse order change

docs/repository_agents.md Outdated Show resolved Hide resolved
docs/repository_agents.md Outdated Show resolved Hide resolved
@deadeyegoodwin deadeyegoodwin merged commit 25d62f9 into master Feb 10, 2021
@deadeyegoodwin deadeyegoodwin deleted the davidg-doc branch February 10, 2021 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants