fix: Verify MemoryShm::byte_size inside shared memory boundary #406
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do?
When attacker registers the same shm created by python backend, they can overwrite
MemoryShm::byte_size
data with a very large value. Identity model will read a large chunk of sensitive data (e.g. glibc.so) as input tensor, copy to the output tensor and send back to the client.Checklist
<commit_type>: <Title>
Commit Type:
Related PRs:
Where should the reviewer start?
Test plan:
30911637
Caveats:
Background
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)