Conversation
rmccorm4
reviewed
Dec 12, 2023
nnshah1
reviewed
Dec 12, 2023
Tabrizian
approved these changes
Dec 13, 2023
Member
Tabrizian
left a comment
There was a problem hiding this comment.
Is it going to be cherry-picked for 23.12?
rmccorm4
approved these changes
Dec 13, 2023
Contributor
Author
This is to fix a segfault so I think we could if we have not staged the container. @tanmayv25 May I have your thoughts on this? |
Tabrizian
reviewed
Dec 15, 2023
Tabrizian
approved these changes
Dec 15, 2023
krishung5
added a commit
that referenced
this pull request
Dec 15, 2023
* Set release flags and clean up response factory map before returning error * Address comments * Move the cleanup function to the outside scope * Delete response factory when response sender goes out of scope
krishung5
added a commit
that referenced
this pull request
Dec 15, 2023
mc-nv
pushed a commit
that referenced
this pull request
Dec 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixed the segfault issues:
raise Exception("Intentional Error")without sending any final flag via response sender.response_sendergoes out of scope in the Python model to avoid memory growth.Added testing: triton-inference-server/server#6686