fix: update LLM profiling CLI command #991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-david-oy
changed the title
Update copyright Fix years in copyright
the-david-oy
force-pushed
the
doy-llm
branch
from
6a94c2b to
b6746e3
Compare
nv-hwoo
approved these changes
Dec 1, 2025
the-david-oy
added a commit
that referenced
this pull request
Dec 2, 2025
The copyright checker was failing because PR #991 converted perf_analyzer.py to SPDX format, but the check_copyright.py script only supported the old Apache license format. This commit updates qa/common/check_copyright.py to recognize both: 1. Old Apache format: Copyright 2020-2023, NVIDIA CORPORATION... (followed by full Apache 2.0 license text) 2. SPDX format: SPDX-FileCopyrightText: Copyright (c) 2020-2025... (followed by SPDX-License-Identifier: Apache-2.0) The script now detects which format is used and validates accordingly. Both formats support year ranges and validate that: - Start year is not greater than current year - End year is not greater than current year - Years are in increasing order Tested with both SPDX files (perf_analyzer.py) and old Apache format files (perf_config.py). All existing files pass validation. Remove comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Model Analyzer's LLM profiling mode. GenAI-Perf changed its command line to have a
profilesubcommand, which broke the LLM mode for Model Analyzer.Also, make the model type more case-insensitive for flexibility.