Temporary fix for upstream cuML issues #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include cuML header directory that is currently nested one layer too deep (to be fixed by rapidsai/cuml#3901) Ignore unused variable warnings due to unused variable in fil.h introduced by rapidsai/cuml#3763
|
This PR allows builds to go forward while two upstream problems are addressed. The issue with include directory nesting already has a fix that is just stuck on CI issues, so the corresponding line should be removed from CMakeLists.txt before release. The other may need to remain in place until after 21.06. |
|
Is the ENV{CONDA_PREFIX} safe even after rapidsai/cuml#3901 is merged? |
hcho3
previously approved these changes
May 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include cuML header directory that is currently nested one layer too deep (to be fixed by rapidsai/cuml#3901)
Ignore unused variable warnings due to unused variable in fil.h introduced by rapidsai/cuml#3763