feat: Incorporate "additional-dependency-dirs" #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
fpetrini15
changed the title
GuanLuo
reviewed
Oct 15, 2024
mc-nv
reviewed
Oct 16, 2024
|
I'm against managing environment variables out of the source code. |
fpetrini15
force-pushed
the
fpetrini-additional-dep-dir
branch
from
ac2623a
to
74d1887
Compare
GuanLuo
previously approved these changes
Oct 21, 2024
fpetrini15
force-pushed
the
fpetrini-additional-dep-dir
branch
from
d277f13
to
6468f3b
Compare
rmccorm4
reviewed
Oct 22, 2024
Comment on lines
+327
to
+332
| std::wstring path_after; | ||
| DWORD len = GetEnvironmentVariableW(PATH.c_str(), NULL, 0); | ||
| if (len > 0) { | ||
| path_after.resize(len); | ||
| GetEnvironmentVariableW(PATH.c_str(), &path_after[0], len); | ||
| } |
There was a problem hiding this comment.
Don't need to change in this PR, but looks like this pattern of
- check size of env var
- resize local string
- write env var to string
is used at least 3 times - probably good to be a helper function in the future
rmccorm4
approved these changes
Oct 23, 2024
GuanLuo
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Adds core support for a new "additional-dependency-dirs" configuration option that will add user-specified directories to the search path during backend loading.
Checklist
<commit_type>: <Title>Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
Server: triton-inference-server/server#7707
[WIP]