-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure the GRPC client code #292
Conversation
except ModuleNotFoundError as error: | ||
raise RuntimeError( | ||
'The installation does not include grpc support. ' | ||
'Specify \'grpc\' or \'all\' while installing the tritonclient ' | ||
'package to include the support') from error | ||
|
||
import grpc |
Check notice
Code scanning / CodeQL
Module is imported more than once
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if these warnings points to a real issue here. Which grpc module will be imported?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I double checked. The correct gRPC is used: /usr/local/lib/python3.8/dist-packages/grpc/init.py
b21fcba
to
0be1c7f
Compare
Before
After:
I've made sure the API to the user is the same before and after this change.