Fix perf analyzer build and add better logging #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoderHam
approved these changes
Aug 13, 2021
| @@ -43,6 +43,8 @@ option(TRITON_ENABLE_GPU "Enable GPU support in libraries" OFF) | |||
|
|
|||
| set(TRITON_COMMON_REPO_TAG "main" CACHE STRING "Tag for triton-inference-server/common repo") | |||
| set(TRITON_THIRD_PARTY_REPO_TAG "main" CACHE STRING "Tag for triton-inference-server/third_party repo") | |||
| set(TRITON_CORE_REPO_TAG "main" CACHE STRING "Tag for triton-inference-server/core repo") | |||
There was a problem hiding this comment.
This is needed only for the C API right?
@deadeyegoodwin @tanmayv25 we should have build flags to enable/disable the C API, TF Serving and torchserve support. So that users can customize the client library build if they require.
@jbkyang-nvi Could you also file a ticket for this?
There was a problem hiding this comment.
We already have the ticket. JIRA is under-maintenance hence unable to pull up the exact ticket.
deadeyegoodwin
approved these changes
Aug 14, 2021
deadeyegoodwin
pushed a commit
that referenced
this pull request
Aug 14, 2021
…ackend versions (#25)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Server repo: triton-inference-server/server#3232
Tritonserver: https://gitlab-master.nvidia.com/dl/dgx/tritonserver/-/merge_requests/356
Client repo: #25