Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'plist-load' feature, analogous to existing 'yaml-load' feature #345

Merged
merged 4 commits into from
Aug 19, 2021

Commits on Aug 9, 2021

  1. Move impl Default for FontStyle to where it belongs

    Namely to the same file in which FontStyle is declared.
    
    This will make it easier to introduce a theme_load.rs file later.
    Enselic committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    8f95381 View commit details
    Browse the repository at this point in the history
  2. Remove trait FromSettings which has never been used for anything

    It is safe to remove because it has never been re-exported as public API.
    Enselic committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    2489234 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2021

  1. Move theme loading code from theme.rs to new theme_load.rs

    To make it easier to later introduce a 'plist-load' feature similar
    to the existing 'yaml-load' feature, but for themes and not syntaxes.
    
    I have confirmed that this change does not affect the public API.
    Enselic committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    1a9cda6 View commit details
    Browse the repository at this point in the history
  2. Make 'plist' dependency optional via new 'plist-load' feature

    plist brings in several dependencies, most notably the heavy xml-rs dependency.
    So if you don't need to parse theme files, it is nice to be able to skip
    this dependency.
    
    For example it brings down the number of dependencies to build from 68 to 52
    when building examples/synhtml.rs as a regular app. And build time shrinks
    proportionally. Try yourself with:
    
        cp examples/synhtml.rs src/main.rs # temporarily side-step dev-dependencies
        cargo build --no-default-features --features parsing,html,assets,dump-load,regex-onig
    Enselic committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    ffa65b1 View commit details
    Browse the repository at this point in the history