-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Widen compat bounds, bump version #41
Widen compat bounds, bump version #41
Conversation
The conflict with PrettyTables is preventing me from using the latest version of PrettyTables in my package StableSpectralElements.jl. Would someone (@ffevotte?) be willing to review and merge this PR? Thanks so much! |
Yes, I'm very sorry about not taking proper care of the package in the past few months. Unfortunately it looks like some things have broken for Julia 1.9+ |
Thanks a lot @charleskawczynski for this PR! I took the liberty of rebasing it in #46, in which I also introduced a few changes:
@tristanmontoya does this work for you? In any case, I'm going to close this PR, considering that it is superseded by #46, but if any of you feel like I missed something, please do not hesitate to re-open it. Thanks again! |
@ffevotte thanks so much - it works for me! |
Hi @ffevotte, sounds good to me, and thanks for getting that merged! Are you planning to eventually update Cassette? |
Do you have a specific |
Ah, yes, the latest one. I just realized the previous compat should be fine for updating. All is well, thanks again! |
Hello, and thanks for the great package! This PR widens the compat bounds so that users can upgrade to newer versions.
This passes all the tests for me with julia 1.7 and 1.8