This repository has been archived by the owner on Dec 17, 2024. It is now read-only.
Feature/2.1.0 #14
Merged
Feature/2.1.0 #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbruce
suggested changes
Sep 23, 2019
| val leftOutputColumns = leftView.columns.map{columnName => col(s"datasetA.${columnName}")} | ||
| val rightOutputColumns = rightView.columns.map{columnName => col(s"datasetB.${columnName}")} | ||
|
|
||
| pipelineModel.stages(3).asInstanceOf[MinHashLSHModel] |
There was a problem hiding this comment.
Consider searching for the MinHashLSHModel instead of by index in case the position changes in the future
| } | ||
|
|
||
| // build locality-sensitive hashing model | ||
| val minHashLSH = { new MinHashLSH() |
There was a problem hiding this comment.
Minor style suggestion to remove the surrounding brackets as it doesn't require a block (same for above)
|
|
||
| pipelineModel.stages(3).asInstanceOf[MinHashLSHModel] | ||
| .approxSimilarityJoin(datasetA, datasetB, (1.0-stage.threshold)) | ||
| .select((leftOutputColumns ++ rightOutputColumns ++ List((lit(1.0)-col("distCol")).alias("similarity"))):_*) |
There was a problem hiding this comment.
Do you specifically need a list here or can it just be a generic Seq?
| before(head) | ||
| val result = processStage(head) | ||
| after(head, result, true) | ||
| val stage = head._1 |
There was a problem hiding this comment.
It should be possible to do this in the match:
case (stage, index) :: Nil
| val result = processStage(head) | ||
| after(head, result, false) | ||
| val stage = head._1 | ||
| val index = head._2 |
There was a problem hiding this comment.
It should be possible to do this in the match:
case (stage, index) :: tail
jbruce
approved these changes
Sep 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add change to Lifecycle Hook API and add additional config reader types