Minor cleanups in Pinot connector #9178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashhar
approved these changes
Sep 9, 2021
|
@elonazoulay LGTM otherwise. |
Creation of indices without dictionaries is not supported for multivalued pinot columns.
elonazoulay
force-pushed
the
pinot_fixes
branch
from
5fc2a82 to
ff6c861
Compare
elonazoulay
force-pushed
the
pinot_fixes
branch
from
ff6c861 to
856c9e8
Compare
hashhar
approved these changes
Sep 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor fixes to the pinot connector: