Resolve issue with OAuth2 product tests and reenable #8779
Conversation
11xor6
requested review from
findepi,
kokosing,
Praveen2112 and
lukasz-walkiewicz
11xor6
force-pushed
the
11xor6/reenable-oauth2-pt
branch
from
fb5a53f
to
d7cd715
Compare
| @@ -126,6 +126,7 @@ private WebDriver getWebDriver() | |||
| { | |||
| ChromeOptions options = new ChromeOptions(); | |||
| options.setAcceptInsecureCerts(true); | |||
| options.addArguments("--disable-gpu"); | |||
There was a problem hiding this comment.
Should there be a TODO to remove this once resolved upstream? Or does it not matter?
There was a problem hiding this comment.
A TODO might be a good option here, but it also may not matter. Given that it's docker I can't imagine it'll ever actually use the GPU. I could go either way; I'll add the TODO tomorrow if this PR hasn't been merged as I'm dog tired and done for today.
There was a problem hiding this comment.
Sure, no problem. Also, can you please add the reason in the commit message too.
There was a problem hiding this comment.
So Selenium just released a new version of the Chrome container thus I've just removed the work around entirely. I did add the reason in the commit message with links to the Selenium and Chrome tickets.
11xor6
force-pushed
the
11xor6/reenable-oauth2-pt
branch
from
d7cd715
to
d56e30c
Compare
Apparently there is an issue with Chrome 92 when running inside a Docker container. This has been resolved with another release of the Selenium Chrome container, thus all that is needed is to reenable the product tests. The links below outline the issue if more detail is required. See: * SeleniumHQ/docker-selenium#1346 * SeleniumHQ/docker-selenium#1351 * https://bugs.chromium.org/p/chromium/issues/detail?id=1228625 Related to trinodb#8756
11xor6
force-pushed
the
11xor6/reenable-oauth2-pt
branch
from
d56e30c
to
86d6226
Compare
|
I think we should pin exact (immutable) version anyway in order to avoid such issues in future. |
Apparently there is an issue with Chrome 92 when running inside a Docker container. This PR implements the workaround suggested in the following links and reenables the OAuth2 product tests.
See:
An alternate solution is to pin
selenium/standalone-chrome-debugto tag3.141.59-20210713(inSeleniumChrome).Related to #8756