-
Notifications
You must be signed in to change notification settings - Fork 3.4k
[Doc] Add user guide for Pulsar connector #8469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Anonymitaet.
|
|
@mosabua could you please help review? Many thanks |
|
Hi @mosabua, could you please help answer my questions? Many thanks! Q1. This the 1st time I contribute content to Trino. Q2. do my settings affect me submitting this PR? |
|
@Anonymitaet you need to check what email you are using in your local git config and that email needs to be registered with github. Your screenshots look correct. You just have to submit a signed CLA and then @martint or another maintainer will file it and update https://github.com/trinodb/cla/blob/master/contributors .. then the CLA check on this PR can pass. |
|
I will review tomorrow, but just fyi @electrum this PR is based on a google doc we collaborated on with @Anonymitaet and @MarvinCai so it should be pretty good already. |
|
Please format all paragraphs to 80 column width in the source @Anonymitaet |
|
Please keep in mind that we cannot merge documentation without merging first code. Surely, code can change during the code review process. |
|
@kokosing we are aware. The plan is to get the code and the doc PR to good enough quality on both sides in parallel and then merge both together so they end up shipping in the same release. |
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Anonymitaet.
|
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Anonymitaet.
|
|
@mosabua thanks for your explanations! I've rewrapped the texts, could you please help review? |
| * Pulsar 2.8.0 or higher. | ||
|
|
||
| * Network access from the Trino coordinator and workers to the Pulsar web | ||
| service API. 8080 is the default port. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to indent this so that "Network" and "service" line up.. same applies to all other list items..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mosabua thanks for your instruction! I've indented and successfully previewed the contents:
Any other comments on this doc PR?
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Anonymitaet.
|
Hi @martint, I see my name in https://github.com/trinodb/cla/blob/master/contributors but seems that CLA checks fail. Could you please give some instructions on this? Thanks |
|
@cla-bot check |
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Anonymitaet.
|
|
The cla-bot has been summoned, and re-checked this pull request! |
@Anonymitaet the commits are not associated with your github id. if you don't want to use your actual email address in the commits, see https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-github-user-account/managing-email-preferences/setting-your-commit-email-address#setting-your-commit-email-address-on-github for github-provided noreply-type email address. |
|
Hi @findepi many thanks for your guidance! Double-check if my understanding is correct, do you mean changing my primary email to anonymitaet_@hotmail.com (it is used to register my GitHub account)? |
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Anonymitaet.
|
|
Hi @findepi I've fixed the issue and pushed a commit. But the CLA bot appeared again and the CLA tests still fail. What should I do? Many thanks for your help! |
|
I've re-submitted a PR #8977 and the CLA test pass, so I will close this PR. |
awesome that you figured this out! |








Hi Trino community,
Pulsar community is contributing the
Pulsar connectorto Trino with code and docs:Code PR: [Connector]Add plugin for Apache Pulsar. #8020
Doc PR: we wrote and discussed the contents in google doc before.
After finalizing the contents, I send this PR.
I preview the contents in my local machine, everything goes fine.
Pulsar connector guide
Pulsar connector tutorial guide