Skip to content

Conversation

@Anonymitaet
Copy link

@Anonymitaet Anonymitaet commented Jul 5, 2021

Hi Trino community,

Pulsar community is contributing the Pulsar connector to Trino with code and docs:

Pulsar connector guide

image

Pulsar connector tutorial guide

image

@cla-bot
Copy link

cla-bot bot commented Jul 5, 2021

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Anonymitaet.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@Anonymitaet
Copy link
Author

@mosabua could you please help review? Many thanks

@Anonymitaet
Copy link
Author

Anonymitaet commented Jul 5, 2021

Hi @mosabua, could you please help answer my questions? Many thanks!

Q1. This the 1st time I contribute content to Trino.
I've sent my signed CLA to cla@trino.io, anything else I need to do?

Q2. do my settings affect me submitting this PR?

image

image

@mosabua
Copy link
Member

mosabua commented Jul 5, 2021

@Anonymitaet you need to check what email you are using in your local git config and that email needs to be registered with github. Your screenshots look correct.

You just have to submit a signed CLA and then @martint or another maintainer will file it and update https://github.com/trinodb/cla/blob/master/contributors .. then the CLA check on this PR can pass.

@mosabua
Copy link
Member

mosabua commented Jul 5, 2021

I will review tomorrow, but just fyi @electrum this PR is based on a google doc we collaborated on with @Anonymitaet and @MarvinCai so it should be pretty good already.

@mosabua
Copy link
Member

mosabua commented Jul 5, 2021

Please format all paragraphs to 80 column width in the source @Anonymitaet

@kokosing
Copy link
Member

kokosing commented Jul 5, 2021

Please keep in mind that we cannot merge documentation without merging first code. Surely, code can change during the code review process.

@mosabua
Copy link
Member

mosabua commented Jul 5, 2021

@kokosing we are aware. The plan is to get the code and the doc PR to good enough quality on both sides in parallel and then merge both together so they end up shipping in the same release.

@cla-bot
Copy link

cla-bot bot commented Jul 6, 2021

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Anonymitaet.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot
Copy link

cla-bot bot commented Jul 6, 2021

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Anonymitaet.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@Anonymitaet
Copy link
Author

@mosabua thanks for your explanations! I've rewrapped the texts, could you please help review?

* Pulsar 2.8.0 or higher.

* Network access from the Trino coordinator and workers to the Pulsar web
service API. 8080 is the default port.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to indent this so that "Network" and "service" line up.. same applies to all other list items..

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mosabua thanks for your instruction! I've indented and successfully previewed the contents:

image

Any other comments on this doc PR?

@cla-bot
Copy link

cla-bot bot commented Jul 7, 2021

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Anonymitaet.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@Anonymitaet
Copy link
Author

@Anonymitaet you need to check what email you are using in your local git config and that email needs to be registered with github. Your screenshots look correct.

You just have to submit a signed CLA and then @martint or another maintainer will file it and update https://github.com/trinodb/cla/blob/master/contributors .. then the CLA check on this PR can pass.

Hi @martint, I see my name in https://github.com/trinodb/cla/blob/master/contributors but seems that CLA checks fail. Could you please give some instructions on this? Thanks

image

@findepi
Copy link
Member

findepi commented Aug 25, 2021

@cla-bot check

@cla-bot
Copy link

cla-bot bot commented Aug 25, 2021

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Anonymitaet.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot
Copy link

cla-bot bot commented Aug 25, 2021

The cla-bot has been summoned, and re-checked this pull request!

@findepi
Copy link
Member

findepi commented Aug 25, 2021

Hi @martint, I see my name in https://github.com/trinodb/cla/blob/master/contributors but seems that CLA checks fail. Could you please give some instructions on this? Thanks

@Anonymitaet the commits are not associated with your github id.
See for example https://github.com/trinodb/trino/pull/8469/commits - "Anonymitaet" should be a link to your profile (like on https://github.com/trinodb/trino/pull/8935/commits)
it's not, because the email you use in git (git config --global) is not associated with your github profile.
Actually, it's not a valid email address at all.

if you don't want to use your actual email address in the commits, see https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-github-user-account/managing-email-preferences/setting-your-commit-email-address#setting-your-commit-email-address-on-github for github-provided noreply-type email address.

@Anonymitaet
Copy link
Author

Anonymitaet commented Aug 25, 2021

Hi @findepi many thanks for your guidance!

Below are my settings:
image

image

Double-check if my understanding is correct, do you mean changing my primary email to anonymitaet_@hotmail.com (it is used to register my GitHub account)?

@cla-bot
Copy link

cla-bot bot commented Aug 25, 2021

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Anonymitaet.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@Anonymitaet
Copy link
Author

Hi @findepi

I've fixed the issue

image

and pushed a commit. But the CLA bot appeared again and the CLA tests still fail.

What should I do? Many thanks for your help!

image

@Anonymitaet
Copy link
Author

I've re-submitted a PR #8977 and the CLA test pass, so I will close this PR.
Many thanks for your guidance! @MarvinCai

@findepi
Copy link
Member

findepi commented Aug 26, 2021

I've re-submitted a PR #8977 and the CLA test pass, so I will close this PR.

awesome that you figured this out!

@findepi findepi closed this Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants