Fix getting views for Hive 2.3+ metastore #833
Conversation
|
Nice trick! |
|
@electrum see https://issues.apache.org/jira/browse/HIVE-12274 ("Increase width of columns used for general configuration in the metastore.") diff, how it touches the tests. argh, but Hive < 2.3 did not support |
findepi
force-pushed
the
findepi/master/fix-getting-views-for-hive-2-3-metastore-7f951e
branch
from
8e9448d to
c5a8354
Compare
Hive 2.3 metastore provides more space for table parameter values. On certain databases (e.g. Derby, Oracle) it uses CLOB and these databases disallow `=` predicates over CLOB values. At the same time, they allow `LIKE` predicates over them. This fixes `SHOW TABLES` and queries over `information_schema.tables`.
findepi
force-pushed
the
findepi/master/fix-getting-views-for-hive-2-3-metastore-7f951e
branch
from
c5a8354 to
d5b6f27
Compare
| @@ -117,6 +117,9 @@ | |||
| private final Duration maxRetryTime; | |||
| private final int maxRetries; | |||
|
|
|||
| private volatile boolean metastoreKnownToSupportTableParamEqualsPredicate; | |||
There was a problem hiding this comment.
Maybe shorten KnownToSupport to Supports
There was a problem hiding this comment.
Then i wouldn't be able to use false as an initial value (because initially i don't know yet).
| return views; | ||
| } | ||
| catch (TException | RuntimeException secondException) { | ||
| if (firstException != secondException) { |
There was a problem hiding this comment.
Why would firstException == secondException?
There was a problem hiding this comment.
Technically you can keep an exception and rethrow it multiple times. I see no particular reason why this could happen here.
Apparently we often guard calls to java.lang.Throwable#addSuppressed like this (for apparently no particular reason), so I am blindly following an established convention 😉
There was a problem hiding this comment.
It seems unlikely to happen in practice but is a good safety measure.
findepi
deleted the
findepi/master/fix-getting-views-for-hive-2-3-metastore-7f951e
branch
On certain databases (e.g. Derby, Oracle) it uses CLOB and these databases disallow `=` predicates over CLOB values. At the same time, they allow `LIKE` predicates over them. cherry-picked : trinodb/trino#833
Hive 2.3 metastore provides more space for table parameter values. On
certain databases (e.g. Derby, Oracle) it uses CLOB and these databases
disallow
=predicates over CLOB values. At the same time, they allowLIKEpredicates over them.This fixes
SHOW TABLESand queries overinformation_schema.tables.Also, fixes prestodb/presto#10735, nico-arianto/big-data-local#1.