Correct assumption that OIDC access token is always a JWT #8250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11xor6
force-pushed
the
fix-access-token-assumption
branch
3 times, most recently
from
76d9b06
to
0895543
Compare
11xor6
force-pushed
the
fix-access-token-assumption
branch
from
0895543
to
299b40c
Compare
lukasz-walkiewicz
approved these changes
Jun 15, 2021
| this.service = requireNonNull(service, "service is null"); | ||
| this.principalField = config.getPrincipalField(); |
| { | ||
| return jwtParser.parseClaimsJws(jws); | ||
| return Optional.ofNullable(jwtParser.parseClaimsJws(token) |
There was a problem hiding this comment.
I think that moving jwtParser.. part to the next line would create an additional indent and thus improve readability slightly.
|
Closing this in favor of #8641 which superceeds this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an assumption that the OAuth2/OIDC access token is always a JWT, this is not always the case as the OAuth2 and OIDC specifications both specify that it's implementation is undefined.
See: https://datatracker.ietf.org/doc/html/rfc6749#section-1.4 (OIDC defers to the OAuth2 definition of access tokens here: https://openid.net/specs/openid-connect-core-1_0.html#Terminology)