Skip to content

Conversation

@pj-spoelders
Copy link
Contributor

@pj-spoelders pj-spoelders commented Dec 12, 2025

Description

This PR aims to re-enable the Exasol product tests.
We have updated the used Exasol test container to a version that uses less disk space. This solves the CI runner space pressure issue that made the product tests fail occasionally and made them flaky.

Additional context and related issues

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

@cla-bot cla-bot bot added the cla-signed label Dec 12, 2025
@github-actions github-actions bot added the exasol Exasol connector label Dec 12, 2025
@ebyhr
Copy link
Member

ebyhr commented Dec 12, 2025

Update Exasol Containers
Uses a specificially tailored container that uses less disk space to solve CI runner disk space issue.

The commit body is too long. https://trino.io/development/process.html#pull-request-and-commit-guidelines- is our commit message's guideline.

  • Wrap the body at 72 characters.

@pj-spoelders pj-spoelders force-pushed the exasol/enable_exasol_product_tests_update_testcontainers branch 2 times, most recently from cc22c1c to 1dec42a Compare December 12, 2025 12:11
@pj-spoelders pj-spoelders marked this pull request as ready for review December 12, 2025 16:05
@pj-spoelders pj-spoelders force-pushed the exasol/enable_exasol_product_tests_update_testcontainers branch from 79381c6 to 4347bcb Compare December 12, 2025 16:05
@pj-spoelders pj-spoelders requested review from ebyhr and findepi and removed request for findepi December 12, 2025 16:37
@pj-spoelders
Copy link
Contributor Author

Update Exasol Containers
Uses a specificially tailored container that uses less disk space to solve CI runner disk space issue.

The commit body is too long. https://trino.io/development/process.html#pull-request-and-commit-guidelines- is our commit message's guideline.

  • Wrap the body at 72 characters.

Wrapped.

@ebyhr
Copy link
Member

ebyhr commented Dec 12, 2025

Is "Update exasol-testcontainers" commit required for green CI?
What was the cause of "Could not detect internal BucketFS port for custom image 'exadockerci4/docker-db:2025.1.8_dev_java_slc_only'. Please specify the port explicitly using withExposedPorts()." https://github.com/trinodb/trino/actions/runs/20166360006?

@pj-spoelders
Copy link
Contributor Author

pj-spoelders commented Dec 13, 2025

Is "Update exasol-testcontainers" commit required for green CI? What was the cause of "Could not detect internal BucketFS port for custom image 'exadockerci4/docker-db:2025.1.8_dev_java_slc_only'. Please specify the port explicitly using withExposedPorts()." https://github.com/trinodb/trino/actions/runs/20166360006?

The commit is required to fix the CI action:
In exasol-testcontainers, at container startup, we parse and check the docker tag/version to define the bucketfs ports that are used.
In this case the tag we used has underscores and the regex used to extract parts of the version struggled with this. In the new version of exasol-testcontainers the regex has been changed to properly handle these new version tags as well.
So this makes everything work correctly again.

@pj-spoelders pj-spoelders force-pushed the exasol/enable_exasol_product_tests_update_testcontainers branch from 4347bcb to d8b46b8 Compare December 13, 2025 11:54
Uses a tailored container that uses less disk space,
this solves the CI runner disk space issue we were experiencing.
@ebyhr ebyhr force-pushed the exasol/enable_exasol_product_tests_update_testcontainers branch from d8b46b8 to ae10c3d Compare December 13, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed exasol Exasol connector

Development

Successfully merging this pull request may close these issues.

2 participants