Report written rows and size by MERGE statement #27332
Merged
+95
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
force-pushed
the
ebi/core-missing-metrics
branch
2 times, most recently
from
35d8ee7 to
d00e9f6
Compare
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeMergeSink.java
Outdated
Show resolved
Hide resolved
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeMergeSink.java
Outdated
Show resolved
Hide resolved
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeMergeSink.java
Show resolved
Hide resolved
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeMergeSink.java
Outdated
Show resolved
Hide resolved
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeMergeSink.java
Show resolved
Hide resolved
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMergeSink.java
Outdated
Show resolved
Hide resolved
core/trino-spi/src/main/java/io/trino/spi/connector/ConnectorMergeSink.java
Outdated
Show resolved
Hide resolved
core/trino-spi/src/main/java/io/trino/spi/connector/ConnectorMergeSink.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/core-missing-metrics
branch
from
d00e9f6 to
5131199
Compare
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeMergeSink.java
Show resolved
Hide resolved
raunaqmorarka
approved these changes
Nov 17, 2025
wendigo
reviewed
Nov 17, 2025
| mergePage.updateDeletionsPage().ifPresent(deletions -> processDeletion(deletions, UPDATE_PREIMAGE_CDF_LABEL)); | ||
|
|
||
| writtenBytes = insertPageSink.getCompletedBytes(); | ||
| writtenBytes += cdfPageSink == null ? 0 : cdfPageSink.getCompletedBytes(); |
Contributor
There was a problem hiding this comment.
if statement would be more readable then ternary one
Member
Author
There was a problem hiding this comment.
This is simple enough to me.
wendigo
reviewed
Nov 17, 2025
| assertThat(queryStats.getLogicalWrittenDataSize().toBytes()).isPositive(); | ||
|
|
||
| if (hasBehavior(SUPPORTS_REPORTING_WRITTEN_BYTES)) { | ||
| assertThat(queryStats.getPhysicalWrittenDataSize().toBytes()).isPositive(); |
Contributor
There was a problem hiding this comment.
can we assert on the actual written size?
Member
Author
There was a problem hiding this comment.
I don't think we want to make this assertion complex in the base test class. Such tests can be implemented in each connector, with more detailed scenarios.
ebyhr
force-pushed
the
ebi/core-missing-metrics
branch
from
6972f82 to
0a64301
Compare
Member
Author
|
(Just squashed fixup commits) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #25922
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.