Fix preview UI to render long single line SQLs correctly #27328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koszti
force-pushed
the
fix-preview-ui-to-render-single-line-sqls
branch
from
ce98a55 to
1aa0465
Compare
koszti
changed the title
koszti
changed the title
Contributor
|
@koszti I've also noticed recently, while on the plane, that query doesn't render offline as some of the components are fetched over network. Can we make these bundled so that preview UI works offline too? |
Member
Author
oh good to know thanks. i’ll send PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
CodeBlockcomponent in the preview UI doesn't render word-wrapped long lines with the correct height, which results in an incorrect layout. This PR fixes the issue by calculating the height properly.Additional context and related issues
Before:
After (sensitive data is masked):
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: