Added BaseConnectorSmokeTest for Analyze to test different catalogs #27322
Conversation
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
| "NOT_SUPPORTED"); | ||
| } | ||
| finally { | ||
| assertUpdate("DROP TABLE IF EXISTS " + tableName); |
There was a problem hiding this comment.
Could you use TestTable class instead?
| assertThat(query("SELECT count(*) FROM " + tableName)) | ||
| .matches("VALUES BIGINT '25'"); |
There was a problem hiding this comment.
No need to verify the row count. I would remove this assertion.
| assertThat(computeActual("SHOW STATS FOR " + tableName).getRowCount()) | ||
| .as("Statistics should be collected after ANALYZE") | ||
| .isGreaterThan(0); |
There was a problem hiding this comment.
Could you verify distinct_values_count field instead of the row count?
| String tableName = "test_analyze_" + randomNameSuffix(); | ||
|
|
||
| try { | ||
| assertUpdate("CREATE TABLE " + tableName + " AS SELECT * FROM nation", 25); |
There was a problem hiding this comment.
We should verify the following ANALYZE collected NDV. Could you use a session disabling collect_extended_statistics_on_write property?
| .containsAnyOf( | ||
| "S3 Tables do not support analyze", | ||
| "do not support analyze", | ||
| "NOT_SUPPORTED"); |
There was a problem hiding this comment.
We could add a helper method (e.g. errorMessageForAnalyze) and make unsupported test classes override the method.
| } | ||
| } | ||
|
|
||
| @Test |
There was a problem hiding this comment.
Added BaseConnectorSmokeTest for Analyze to test different catalogs
Could you change both PR and commit title to "Test ANALYZE in BaseIcebergConnectorSmokeTest"?
2 participants
Description
This PR adds a test case to BaseConnectorSmokeTest testing that analyze works correctly if the connector supports the operation. If the test fails then it is because of lack of support so the test will then check that the test is indeed true for the underlying connector.
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: