Skip to content

Conversation

@prrvchr
Copy link
Member

@prrvchr prrvchr commented Nov 14, 2025

Description

These changes add the following to the metadata of a ResultSet:

  • the catalog name (if not provided, the default value is an empty string)
  • the schema name (if not provided, the default value is an empty string)
  • the table name (if not provided, the default value is an empty string)
  • the column label (if it exists, otherwise it's the column name)

They are intended to address issue #22306

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

## Section
* Fix some things. ({issue}`22306`)

@cla-bot cla-bot bot added the cla-signed label Nov 14, 2025
@github-actions github-actions bot added the jdbc Relates to Trino JDBC driver label Nov 14, 2025
@prrvchr prrvchr requested review from findepi and martint November 14, 2025 17:28
@prrvchr prrvchr self-assigned this Nov 14, 2025
@prrvchr prrvchr force-pushed the new-rsmd branch 9 times, most recently from b2f3ef3 to f89090c Compare November 14, 2025 23:15
@prrvchr prrvchr requested a review from findepi November 16, 2025 09:25
@prrvchr prrvchr force-pushed the new-rsmd branch 13 times, most recently from 8583dab to 9bf1d1e Compare November 16, 2025 19:55
@prrvchr prrvchr force-pushed the new-rsmd branch 14 times, most recently from 3d52419 to 43eefdd Compare November 17, 2025 02:57
@prrvchr prrvchr force-pushed the new-rsmd branch 2 times, most recently from 71e76fa to f28ac38 Compare November 17, 2025 11:44
@prrvchr
Copy link
Member Author

prrvchr commented Nov 17, 2025

@findepi

Perhaps it would be a good idea to immediately add the missing information that will allow LibreOffice Base to efficiently update ResultSets, namely:

  • ResultSetMetaData.isAutoIncrement(int column)

  • ResultSetMetaData.isReadOnly(int column)

This will allow Base to recognize auto-incremented columns and allow me to know which ones have a calculated value.

@prrvchr prrvchr force-pushed the new-rsmd branch 2 times, most recently from 19b1944 to 01c4446 Compare November 17, 2025 14:31
@prrvchr
Copy link
Member Author

prrvchr commented Nov 17, 2025

@findepi
Here's the latest complete version. I hope it passes the tests. Thanks in advance for your corrections.

@prrvchr prrvchr force-pushed the new-rsmd branch 2 times, most recently from bc08bf9 to 0d1409d Compare November 17, 2025 14:50
@findepi
Copy link
Member

findepi commented Nov 17, 2025

Perhaps it would be a good idea to immediately add the missing information that will allow LibreOffice Base to efficiently update ResultSets, namely:

  • ResultSetMetaData.isAutoIncrement(int column)
  • ResultSetMetaData.isReadOnly(int column)

I am not ready for this topic. Would prefer for that to be separate PR.

@prrvchr prrvchr force-pushed the new-rsmd branch 2 times, most recently from 71e76fa to 3baf4a3 Compare November 17, 2025 19:53
@prrvchr
Copy link
Member Author

prrvchr commented Nov 17, 2025

@findepi, Okay, I'm reverted and will propose a PR just for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed jdbc Relates to Trino JDBC driver

Development

Successfully merging this pull request may close these issues.

2 participants