Compile trino-server-main targeting Java 11 #27260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By targeting Java 11 we can eliminate manual Java version string parsing. The downside is that someone trying to run Trino server with JDK 8, 9 or 10 won't get a nice error message anymore. The situation is unlikely given how ancient these versions are.
wendigo
approved these changes
Nov 10, 2025
electrum
approved these changes
Nov 10, 2025
| if (major == null || major < 22) { | ||
| Runtime.Version javaVersion = Runtime.version(); | ||
| if (javaVersion.feature() < 22) { | ||
| System.err.printf("ERROR: Trino requires Java 22+ (found %s)%n", javaVersion); |
Member
There was a problem hiding this comment.
Unrelated, but this was missed in the last version update
Member
Author
There was a problem hiding this comment.
we could capture trino-server-core's built-time project.build.targetJdk in a resource, so that we don't have to update the value manually
findepi
deleted the
findepi/compile-trino-server-main-targeting-java-11-320376
branch
Contributor
Should this be mentioned in the release notes? |
findepi
added
the
no-release-notes
Member
Author
|
No. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By targeting Java 11 we can eliminate manual Java version string parsing. The downside is that someone trying to run Trino server with JDK 8, 9 or 10 won't get a nice error message anymore. The situation is unlikely given how ancient these versions are.