Skip to content

Include addresses in retainedSize of IcebergSplit #21644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2024

Conversation

takezoe
Copy link
Member

@takezoe takezoe commented Apr 21, 2024

Description

In IcebergSplit, addresses was once removed in 0371182 and resurrected in 102ce9d but without fixing getRetainedSizeInBytes().

Additional context and related issues

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Apr 21, 2024
@github-actions github-actions bot added the iceberg Iceberg connector label Apr 21, 2024
@wendigo wendigo requested a review from raunaqmorarka April 21, 2024 17:42
@wendigo wendigo merged commit 9bb654a into trinodb:master Apr 21, 2024
@github-actions github-actions bot added this to the 446 milestone Apr 21, 2024
@takezoe takezoe deleted the fix_iceberg_split_retained_size branch May 23, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed iceberg Iceberg connector
Development

Successfully merging this pull request may close these issues.

3 participants