Document table_changes Iceberg table function
#21406
Conversation
| FROM | ||
| TABLE( | ||
| system.table_changes( | ||
| "SCHEMA" => 'default', |
There was a problem hiding this comment.
SCHEMA and TABLE are reserved words, so we'll have to quote them to avoid unwanted sql syntax issues.
cc @martint
There was a problem hiding this comment.
Thats kinda bad .. why did those parameters not use the same approach as in https://trino.io/docs/current/connector/iceberg.html#migrate-table
so schema_name
and table_name
and also stick with lower case parameter names
There was a problem hiding this comment.
could we maybe fix the implementation ?
findinpath
force-pushed
the
findinpath/iceberg-table-changes-docs
branch
from
9db2912 to
22bd647
Compare
findinpath
force-pushed
the
findinpath/iceberg-table-changes-docs
branch
3 times, most recently
from
838a6f5 to
983b48f
Compare
| VALUES | ||
| ('url1', 'domain1', 1), | ||
| ('url2', 'domain2', 2), | ||
| ('url3', 'domain1', 3); |
There was a problem hiding this comment.
are the domain values here and below different on purpose?
There was a problem hiding this comment.
the page_url & domain are supposed to be the primary key so to say of the table that can be used in downstream processes to identify the history of changes performed on a tuple.
Note that the same example slightly adapted is employed in Trino Delta Lake connector as well.
findinpath
force-pushed
the
findinpath/iceberg-table-changes-docs
branch
from
983b48f to
db0edd1
Compare
Description
Documentation follow-up from #15677
Additional context and related issues
Fixes #21227
Iceberg Spark counterpart https://iceberg.apache.org/docs/latest/spark-procedures/#create_changelog_view
Delta Lake
table_changestable function documenation https://trino.io/docs/current/connector/delta-lake.html#table-changesRelease notes
(x) This is not user-visible or is docs only, and no release notes are required.