Add support for writing timestamp_ntz type in Delta #18913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
ebyhr
force-pushed
the
ebi/delta-timestamp-ntz-write
branch
from
ce7a6dd to
967ae8c
Compare
ebyhr
force-pushed
the
ebi/delta-timestamp-ntz-write
branch
4 times, most recently
from
0dfb632 to
4805c17
Compare
ebyhr
force-pushed
the
ebi/delta-timestamp-ntz-write
branch
2 times, most recently
from
7b1590a to
149d70a
Compare
findepi
approved these changes
Sep 19, 2023
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeMetadata.java
Outdated
Show resolved
Hide resolved
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeMetadata.java
Outdated
Show resolved
Hide resolved
| return new ProtocolEntry( | ||
| readerVersion, | ||
| writerVersion, | ||
| readerFeatures.isEmpty() ? Optional.empty() : Optional.of(readerFeatures), |
There was a problem hiding this comment.
Why discern between empty Set of features and no set of features?
There was a problem hiding this comment.
ProtocolEntry has the following logic, so Optional.of(Set.of()) throws an exception for lower reader & writer versions. We could change the logic alternatively.
if (minReaderVersion < MIN_VERSION_SUPPORTS_READER_FEATURES && readerFeatures.isPresent()) {
throw new IllegalArgumentException("readerFeatures must not exist when minReaderVersion is less than " + MIN_VERSION_SUPPORTS_READER_FEATURES);
}
if (minWriterVersion < MIN_VERSION_SUPPORTS_WRITER_FEATURES && writerFeatures.isPresent()) {
throw new IllegalArgumentException("writerFeatures must not exist when minWriterVersion is less than " + MIN_VERSION_SUPPORTS_WRITER_FEATURES);
}
ebyhr
force-pushed
the
ebi/delta-timestamp-ntz-write
branch
from
149d70a to
99bc09d
Compare
ebyhr
force-pushed
the
ebi/delta-timestamp-ntz-write
branch
from
99bc09d to
1cbb6a2
Compare
|
Rebased on master to resolve conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for writing timestamp_ntz type in Delta
Fixes #16927
Release notes
(x) Release notes are required, with the following suggested text: