Convert docs source to markdown #18375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosabua
changed the title
mosabua
force-pushed
the
mm/more-md
branch
2 times, most recently
from
177adb7 to
b0a9262
Compare
mosabua
changed the title
Whoa .. thats weird.. worked in my testing. Let me check some more. |
|
Fixed the issues .. the comment for START inside the table for some reason did not work in new testing .. the sphinx iterative builds are a pain sometimes.. I also adjusted the test .. all should work now |
|
Build failure is an unrelated Iceberg test. |
ebyhr
reviewed
Jul 25, 2023
core/trino-parser/src/main/java/io/trino/sql/ReservedIdentifiers.java
Outdated
Show resolved
Hide resolved
core/trino-parser/src/main/java/io/trino/sql/ReservedIdentifiers.java
Outdated
Show resolved
Hide resolved
mosabua
force-pushed
the
mm/more-md
branch
2 times, most recently
from
e870cbc to
621bca8
Compare
|
Also adjusted for merge of #18431 |
electrum
approved these changes
Jul 26, 2023
- All files in language folder - All files in sql folder - Adjust test for reserved keyword list
This was referenced Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Continued conversion of docs source to markdown/myst
Verified that the output HTML is identical or only differs in whitespace, wrapping and other aspects that do not impact the rendered, visible output.
Additional context and related issues
#17732
#17742
#17759
Release notes
(x) This is not user-visible or docs only and no release notes are required.