Skip to content

Split a test into two #18087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2023
Merged

Split a test into two #18087

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 16 additions & 12 deletions testing/trino-tests/src/test/java/io/trino/tests/TestAggregations.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,18 +90,6 @@ public void testPreAggregate()
"VALUES (22, 2, 11, 64)",
plan -> assertAggregationNodeCount(plan, 4));

assertQuery(
memorySession,
"SELECT " +
"sum(CASE WHEN sequence = 0 THEN value END), " +
"min(CASE WHEN sequence = 1 THEN value ELSE null END), " +
"max(CASE WHEN sequence = 0 THEN value END), " +
"sum(CASE WHEN sequence = 1 THEN value * 2 ELSE 0 END) " +
"FROM test_table " +
"WHERE sequence = 42",
"VALUES (null, null, null, null)",
plan -> assertAggregationNodeCount(plan, 4));

assertQuery(
memorySession,
"SELECT " +
Expand Down Expand Up @@ -155,6 +143,22 @@ public void testPreAggregate()
plan -> assertAggregationNodeCount(plan, 4));
}

@Test
public void testPreAggregateWithFilter()
{
assertQuery(
memorySession,
"SELECT " +
"sum(CASE WHEN sequence = 0 THEN value END), " +
"min(CASE WHEN sequence = 1 THEN value ELSE null END), " +
"max(CASE WHEN sequence = 0 THEN value END), " +
"sum(CASE WHEN sequence = 1 THEN value * 2 ELSE 0 END) " +
"FROM test_table " +
"WHERE sequence = 42",
"VALUES (null, null, null, null)",
plan -> assertAggregationNodeCount(plan, 4));
}

private void assertAggregationNodeCount(Plan plan, int count)
{
assertThat(countOfMatchingNodes(plan, AggregationNode.class::isInstance)).isEqualTo(count);
Expand Down