Skip to content

Simplify the creation of HiveQueryRunner #18086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 29, 2023
Merged

Simplify the creation of HiveQueryRunner #18086

merged 1 commit into from
Jun 29, 2023

Conversation

assaf2
Copy link
Member

@assaf2 assaf2 commented Jun 29, 2023

Description

Simplify the creation of HiveQueryRunner by the Hive connector tests:

  1. No need to override createQueryRunner anymore.
  2. Add more flexibility by using a builder instead of passing specific arguments to the base class.

Release notes

( X ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

@cla-bot cla-bot bot added the cla-signed label Jun 29, 2023
@assaf2 assaf2 requested a review from raunaqmorarka June 29, 2023 12:58
@github-actions github-actions bot added tests:hive hive Hive connector labels Jun 29, 2023
@assaf2 assaf2 self-assigned this Jun 29, 2023
@raunaqmorarka raunaqmorarka merged commit 34a61b8 into trinodb:master Jun 29, 2023
@github-actions github-actions bot added this to the 421 milestone Jun 29, 2023
@colebow colebow mentioned this pull request Jul 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raunaqmorarka raunaqmorarka Awaiting requested review from raunaqmorarka

Assignees

@assaf2 assaf2

Labels
cla-signed hive Hive connector
Milestone
421
Development

Successfully merging this pull request may close these issues.
2 participants
@assaf2 @raunaqmorarka