Skip to content

Update to airlift 234 #18047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 6, 2023
Merged

Update to airlift 234 #18047

merged 3 commits into from
Jul 6, 2023

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented Jun 26, 2023 •
edited
Loading

This change:

  • migrates javax.annotation to jakarta.annotation-api and errorprone_annotations
  • migrates javax.validation to jakarta.validation-api

@cla-bot cla-bot bot added the cla-signed label Jun 26, 2023
@wendigo wendigo requested review from electrum and kokosing June 26, 2023 21:04
@wendigo
Copy link
Contributor Author

wendigo commented Jun 26, 2023

This completes jakarta migration

@github-actions github-actions bot added bigquery BigQuery connector delta-lake Delta Lake connector hive Hive connector hudi Hudi connector iceberg Iceberg connector jdbc Relates to Trino JDBC driver mongodb MongoDB connector tests:hive labels Jun 26, 2023
@wendigo
Copy link
Contributor Author

wendigo commented Jun 26, 2023

I need to update airlift/units as well

@electrum
Copy link
Member

Can you rebase on top of #17984

@electrum
Copy link
Member

Can you also split out the validation change from the jsr305 migration? Those should be unrelated, since the jsr305 annotations are just used for inspections and not used at runtime.

@wendigo wendigo mentioned this pull request Jun 27, 2023
Merged
@wendigo
Copy link
Contributor Author

wendigo commented Jun 27, 2023

airlift/units#32

@wendigo wendigo force-pushed the serafin/jakarta-annotation-validation branch 3 times, most recently from cef0622 to efa349c Compare June 27, 2023 16:16
@wendigo wendigo force-pushed the serafin/jakarta-annotation-validation branch from 606b1d8 to a02bcbe Compare July 4, 2023 16:17
@wendigo wendigo changed the title Update to airlift 234 and airbase 143 Update to airlift 234 Jul 4, 2023
@wendigo
Copy link
Contributor Author

wendigo commented Jul 4, 2023

Rebased and resolved conflicts after sortpom policies were applied

@wendigo wendigo force-pushed the serafin/jakarta-annotation-validation branch from e058437 to b788815 Compare July 5, 2023 08:17
@wendigo wendigo requested review from findepi and losipiuk July 5, 2023 08:22
findepi
findepi reviewed Jul 5, 2023
View reviewed changes
wendigo added 3 commits July 5, 2023 15:42
@wendigo
Migrate @NotThreadSafe to Trino provided annotation
836817a
@wendigo
Disable @immutable error-prone check
50887c0 
Some Trino classes are marked as @immutable but in fact, they are mutable as they contain mutable fields,
which makes them fail the error-prone Immutable check.
@wendigo
Update to airlift 234
15d7103 
This change:

- migrates javax.annotation to jakarta.annotation-api and errorprone_annotations
- migrates javax.validation to jakarta.validation-api
@wendigo wendigo force-pushed the serafin/jakarta-annotation-validation branch from b788815 to 15d7103 Compare July 5, 2023 14:26
@wendigo
Copy link
Contributor Author

wendigo commented Jul 5, 2023

@findepi I've extracted a preparatory commit that introduces io.trino.annotation.NotThreadSafe annotation and addressed rest of your comments

@wendigo
Copy link
Contributor Author

wendigo commented Jul 5, 2023

/test-with-secrets sha=15d710304aaf9cc2510022ba05cc973593ee61b6

@wendigo wendigo requested a review from findepi July 5, 2023 14:56
@wendigo
Copy link
Contributor Author

wendigo commented Jul 6, 2023

Gentle ping @findepi

findepi
findepi approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@findepi findepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First two commits LGTM. Skimmed 3rd.

@wendigo
Copy link
Contributor Author

wendigo commented Jul 6, 2023

I've checked that there is no logical conflict with the master and since there isn't, I'm merging this change.

@wendigo wendigo merged commit f838546 into trinodb:master Jul 6, 2023
@wendigo wendigo deleted the serafin/jakarta-annotation-validation branch July 6, 2023 08:04
@github-actions github-actions bot added this to the 421 milestone Jul 6, 2023
@colebow colebow mentioned this pull request Jul 6, 2023
Merged
@ebyhr ebyhr mentioned this pull request Jan 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@findepi findepi findepi approved these changes

@electrum electrum Awaiting requested review from electrum

@kokosing kokosing Awaiting requested review from kokosing

@losipiuk losipiuk Awaiting requested review from losipiuk

Assignees
No one assigned
Labels
bigquery BigQuery connector cla-signed delta-lake Delta Lake connector hive Hive connector hudi Hudi connector iceberg Iceberg connector jdbc Relates to Trino JDBC driver mongodb MongoDB connector
Milestone
421
Development

Successfully merging this pull request may close these issues.
3 participants
@wendigo @electrum @findepi