Skip to content

Add reusable implementations of comparable and ordering operator for variable width types. #18039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 26, 2023

Conversation

dain
Copy link
Member

@dain dain commented Jun 26, 2023

Description

Add reusable implementations of comparable and ordering operator for variable width types.

Release notes

(x) This is not user-visible or docs only and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label Jun 26, 2023
@github-actions github-actions bot added the mongodb MongoDB connector label Jun 26, 2023
@dain dain requested a review from raunaqmorarka June 26, 2023 05:37
@dain dain force-pushed the variable-width-operators branch from 171499a to fb80bc9 Compare June 26, 2023 05:46
Copy link
Member

@raunaqmorarka raunaqmorarka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm % removal of conflicting change in VarcharType

@dain dain force-pushed the variable-width-operators branch from fb80bc9 to 8d8f899 Compare June 26, 2023 17:42
@dain dain merged commit 4f9be27 into trinodb:master Jun 26, 2023
@dain dain deleted the variable-width-operators branch June 26, 2023 23:52
@github-actions github-actions bot added this to the 421 milestone Jun 27, 2023
@martint martint mentioned this pull request Jul 10, 2023
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed mongodb MongoDB connector
Development

Successfully merging this pull request may close these issues.

2 participants